Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Aug 23, 2025

Close #466

Simulator Screenshot - iPhone 16 Pro - 2025-08-23 at 21 10 40 image

@Kyle-Ye Kyle-Ye requested a review from Mx-Iris August 23, 2025 18:11
@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 35.98131% with 274 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.57%. Comparing base (648aec3) to head (9fdafb2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/CoreGraphicsShims/CATransform3D.swift 10.00% 63 Missing ⚠️
Sources/CoreGraphicsShims/CGAffineTransform.swift 11.29% 55 Missing ⚠️
...tUICore/Render/GeometryEffect/RotationEffect.swift 0.00% 49 Missing ⚠️
...ICore/Render/GeometryEffect/Rotation3DEffect.swift 59.63% 44 Missing ⚠️
...tUICore/Render/GeometryEffect/GeometryEffect.swift 0.00% 20 Missing ⚠️
...Render/GeometryEffect/Rotation3DEffectHelper.swift 52.94% 16 Missing ⚠️
...n/Render/AppKit/NSViewPlatformViewDefinition.swift 0.00% 15 Missing ⚠️
...rt/Layout/Geometry/ProjectionTransformHelper.swift 50.00% 10 Missing ⚠️
...estsSupport/Data/Protobuf/ProtobufTestHelper.swift 95.91% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   15.81%   24.57%   +8.76%     
==========================================
  Files         443      471      +28     
  Lines       24435    27186    +2751     
==========================================
+ Hits         3864     6682    +2818     
+ Misses      20571    20504      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye changed the title Add RotationEffect and Rotataion3DEffect Add RotationEffect and Rotation3DEffect Aug 24, 2025
@Kyle-Ye Kyle-Ye merged commit c6a2dbd into main Aug 24, 2025
8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/rotation branch August 24, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RotationEffect support

2 participants