Skip to content

Conversation

@Mx-Iris
Copy link
Collaborator

@Mx-Iris Mx-Iris commented Sep 7, 2025

No description provided.

@Mx-Iris Mx-Iris requested review from Kyle-Ye and Copilot September 7, 2025 17:21

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Sep 7, 2025

Codecov Report

❌ Patch coverage is 22.13115% with 95 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.68%. Comparing base (1349e96) to head (1670cbf).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ntegration/Hosting/AppKit/View/NSHostingView.swift 22.13% 95 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
+ Coverage   24.67%   24.68%   +0.01%     
==========================================
  Files         474      474              
  Lines       27463    27579     +116     
==========================================
+ Hits         6776     6809      +33     
- Misses      20687    20770      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mx-Iris Mx-Iris requested review from Kyle-Ye and Copilot September 7, 2025 17:36

This comment was marked as outdated.

@Mx-Iris Mx-Iris force-pushed the feature/macos_animation branch from 6360bf4 to 1670cbf Compare September 7, 2025 17:45
@Mx-Iris Mx-Iris requested review from Kyle-Ye and Copilot September 7, 2025 17:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements macOS animation support by adding display link functionality for smooth frame-based animations. The implementation provides a foundation for SwiftUI-style animations on macOS through CoreVideo's display link system.

Key changes include:

  • Addition of a comprehensive DisplayLink C implementation for managing display-synchronized rendering
  • Enhanced NSHostingView with animation timing, async rendering, and update scheduling capabilities
  • New Swift wrapper attributes for improved interoperability between Swift and C types

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.

File Description
Sources/OpenSwiftUI_SPI/OpenSwiftUIBase.h Adds Swift wrapper attribute macro for C struct bridging
Sources/OpenSwiftUI/Integration/Hosting/AppKit/View/NSHostingView.swift Implements animation timing, display link integration, and async rendering logic
Sources/COpenSwiftUI/CoreVideo/DisplayLink.h Defines C API for display link management with Swift name attributes
Sources/COpenSwiftUI/CoreVideo/DisplayLink.c Implements complete display link system with thread-safe management and CoreVideo integration

@Kyle-Ye Kyle-Ye merged commit af23edc into main Sep 7, 2025
11 of 12 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/macos_animation branch September 7, 2025 18:14
@Kyle-Ye Kyle-Ye linked an issue Sep 7, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add macOS Animation support

3 participants