Fix: Add 'package' as valid minimum access level for documentation #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift 5.9+ supports 'package' access level for cross-module APIs within a package. This commit updates build-documentation.sh to accept 'package' as a valid --minimum-access-level option. Changes: - Add 'package' to validation case statement - Update usage documentation to include 'package' - Update error message to list 'package' as valid option Fixes command: ./Scripts/build-documentation.sh --minimum-access-level package
Kyle-Ye
force-pushed
the
fix/docc-package-access-level
branch
from
77a1cae to
304ad35
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
+ Coverage 24.65% 24.67% +0.02%
==========================================
Files 505 505
Lines 29204 29204
==========================================
+ Hits 7200 7206 +6
+ Misses 22004 21998 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 5.9+ supports 'package' access level for cross-module APIs within a package. This commit updates build-documentation.sh to accept 'package' as a valid --minimum-access-level option.
Changes:
Fixes command: ./Scripts/build-documentation.sh --minimum-access-level package