Skip to content

Fix: Move -Wwarning flag to conditional compilation to avoid Xcode conflict #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

Fix: Move -Wwarning flag to conditional compilation to avoid Xcode conflict #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ var sharedSwiftSettings: [SwiftSetting] = [
.enableUpcomingFeature("BareSlashRegexLiterals"),
.enableUpcomingFeature("InternalImportsByDefault"),
.enableUpcomingFeature("InferSendableFromCaptures"),
.unsafeFlags(["-Wwarning", "DeprecatedDeclaration"]), // We want to use deprecated APIs in test targets
// FIXME: -unavailable-decl-optimization=stub is not working somehow (eg. Color.vibrancy). Dig into this later
.unsafeFlags(["-unavailable-decl-optimization=stub"]),
.swiftLanguageMode(.v5),
Expand Down Expand Up @@ -190,6 +189,12 @@ if warningsAsErrorsCondition {
sharedSwiftSettings.append(.unsafeFlags(["-Werror", "Unsafe"]))
sharedSwiftSettings.append(.unsafeFlags(["-Werror", "UnknownWarningGroup"]))
sharedSwiftSettings.append(.unsafeFlags(["-Werror", "ExistentialAny"]))

// This will cause conflict when used by Xcode from a non-local dependency
// "Conflicting options '-Wwarning' and '-suppress-warnings'"
// See: https://forums.swift.org/t/warnings-as-errors-in-sub-packages/70810
// So do not enable it by default here.
sharedSwiftSettings.append(.unsafeFlags(["-Wwarning", "DeprecatedDeclaration"])) // We want to use deprecated APIs in test targets)
}

// MARK: - [env] OPENSWIFTUI_LIBRARY_EVOLUTION
Expand Down
Loading