-
Notifications
You must be signed in to change notification settings - Fork 57
Add Text.LineStyle #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Text.LineStyle #621
Conversation
|
@claude review it |
|
I'll analyze this and get back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements Text.LineStyle functionality for OpenSwiftUI, adding support for text underline and strikethrough styling with various patterns. The implementation includes conversion utilities between Text.LineStyle and NSUnderlineStyle to maintain compatibility with UIKit/AppKit.
- Adds
Text.LineStylestruct with pattern support (solid, dot, dash, dashDot, dashDotDot) - Implements bidirectional conversion between
Text.LineStyleandNSUnderlineStyle - Adds
underline()andstrikethrough()view modifiers with comprehensive test coverage
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Sources/OpenSwiftUICore/Text/Text/TextLineStyle.swift |
Core implementation of Text.LineStyle struct, patterns, and view modifiers |
Sources/OpenSwiftUI/Integration/Graphic/Platform/TextLineStyleConversions.swift |
Conversion extensions between Text.LineStyle and NSUnderlineStyle |
Sources/OpenSwiftUI_SPI/Shims/UIFoundation/NSAttributedString.h |
C header defining NSUnderlineStyle enum for non-Darwin platforms |
Tests/OpenSwiftUICompatibilityTests/Integration/Graphic/Platform/TextLineStyleConversionsCompatibilityTests.swift |
Comprehensive tests for style conversions with edge cases |
...atibilityTests/Integration/Graphic/Platform/TextLineStyleConversionsCompatibilityTests.swift
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
==========================================
+ Coverage 30.33% 30.37% +0.03%
==========================================
Files 548 547 -1
Lines 32851 32495 -356
==========================================
- Hits 9965 9869 -96
+ Misses 22886 22626 -260 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1570c1b to
183fc4d
Compare

No description provided.