Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Nov 1, 2025

No description provided.

@Kyle-Ye Kyle-Ye requested a review from Copilot November 1, 2025 14:38
@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Nov 1, 2025

@claude review it

@claude
Copy link

claude bot commented Nov 1, 2025

Claude Code is working…

I'll analyze this and get back to you.

View job run

@github-actions github-actions bot added enhancement New feature or request platform: iOS platform: macOS test Test related issue labels Nov 1, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements Text.LineStyle functionality for OpenSwiftUI, adding support for text underline and strikethrough styling with various patterns. The implementation includes conversion utilities between Text.LineStyle and NSUnderlineStyle to maintain compatibility with UIKit/AppKit.

  • Adds Text.LineStyle struct with pattern support (solid, dot, dash, dashDot, dashDotDot)
  • Implements bidirectional conversion between Text.LineStyle and NSUnderlineStyle
  • Adds underline() and strikethrough() view modifiers with comprehensive test coverage

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
Sources/OpenSwiftUICore/Text/Text/TextLineStyle.swift Core implementation of Text.LineStyle struct, patterns, and view modifiers
Sources/OpenSwiftUI/Integration/Graphic/Platform/TextLineStyleConversions.swift Conversion extensions between Text.LineStyle and NSUnderlineStyle
Sources/OpenSwiftUI_SPI/Shims/UIFoundation/NSAttributedString.h C header defining NSUnderlineStyle enum for non-Darwin platforms
Tests/OpenSwiftUICompatibilityTests/Integration/Graphic/Platform/TextLineStyleConversionsCompatibilityTests.swift Comprehensive tests for style conversions with edge cases

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.37%. Comparing base (2232c01) to head (1570c1b).

Files with missing lines Patch % Lines
...rces/OpenSwiftUICore/Text/Text/TextLineStyle.swift 0.00% 29 Missing ⚠️
...on/Graphic/Platform/TextLineStyleConversions.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
+ Coverage   30.33%   30.37%   +0.03%     
==========================================
  Files         548      547       -1     
  Lines       32851    32495     -356     
==========================================
- Hits         9965     9869      -96     
+ Misses      22886    22626     -260     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye force-pushed the feature/text_line_style branch from 1570c1b to 183fc4d Compare November 2, 2025 19:03
@Kyle-Ye Kyle-Ye merged commit 74f1693 into main Nov 2, 2025
0 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/text_line_style branch November 2, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request platform: iOS platform: macOS test Test related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants