Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 2, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 2, 2026

🤖 Augment PR Summary

Summary: This PR updates how ViewGraph.NextUpdate computes its effective update interval to better match the audited 6.5.4 behavior.

Changes:

  • Adds internal tracking (_defaultIntervalWasRequested) to distinguish “default interval requested” from an explicitly chosen interval.
  • Adjusts interval(_:reason:) and maxVelocity(_:) so that when a default interval is requested, the graph won’t end up selecting a slower-than-60Hz interval.
  • Expands unit tests to cover maxVelocity thresholds and interval/reason behavior.

Technical Notes: Default intervals are represented internally as .infinity and exposed as 0 via interval, aligning with downstream usage (e.g., CAFrameRateRange(interval:) treating 0 as .default).

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 28.82%. Comparing base (2b3441a) to head (f35a896).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/View/Graph/ViewGraph.swift 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
+ Coverage   28.77%   28.82%   +0.04%     
==========================================
  Files         589      589              
  Lines       35775    35780       +5     
==========================================
+ Hits        10295    10313      +18     
+ Misses      25480    25467      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 4c855cf into main Jan 2, 2026
8 of 10 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/next_update branch January 2, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants