Update OpenAttributeGraph integration and add Compute backend support#800
Merged
Update OpenAttributeGraph integration and add Compute backend support#800
Conversation
🤖 Augment PR SummarySummary: This PR updates OpenSwiftUI’s OpenAttributeGraph integration by renaming backend-selection environment variables and introducing an opt-in Compute backend path. Changes:
Technical Notes: Backend selection is now controlled via OpenAttributeGraphShims-style env flags, and CI is adjusted accordingly. 🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
==========================================
+ Coverage 27.58% 27.66% +0.08%
==========================================
Files 657 652 -5
Lines 41220 40756 -464
==========================================
- Hits 11370 11276 -94
+ Misses 29850 29480 -370 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENATTRIBUTESHIMS_ATTRIBUTEGRAPH/OPENATTRIBUTESHIMS_COMPUTEconvention (prefixed withOPENSWIFTUI_)swiftToolchainrelated build logic (SWIFT_TOOLCHAIN_PATH,SWIFT_TOOLCHAIN_VERSION,SWIFT_TOOLCHAIN_SUPPORTED,LIB_SWIFT_PATH) and associated unsafe flagsOPENSWIFTUI_ATTRIBUTEGRAPH/OPENSWIFTUI_COMPUTEdefines to C and C++ settings (previously Swift-only)Test plan
OPENSWIFTUI_OPENATTRIBUTESHIMS_ATTRIBUTEGRAPH=1OPENSWIFTUI_OPENATTRIBUTESHIMS_COMPUTE=1