[NFC] Optimize source filenames to match the original ID#826
Conversation
🤖 Augment PR SummarySummary: This PR is a non-functional cleanup to align OpenSwiftUI/OpenSwiftUICore source filenames and embedded IDs with SwiftUI’s original file naming/ID mapping. Changes:
Technical Notes: Primary impact is source organization and ID consistency; functional behavior should remain unchanged aside from resolving ID/hash mapping discrepancies. 🤖 Was this summary useful? React with 👍 or 👎 |
|
|
||
| struct CoreUIDefaultSystemColorDefinition: SystemColorDefinition { | ||
| static func value(for type: SystemColorType, environment: EnvironmentValues) -> Color.Resolved { | ||
| #if canImport(Darwin) && OPENSWIFTUI_LINK_COREUI |
There was a problem hiding this comment.
CoreUIDefaultSystemColorDefinition.value contains an inner #if canImport(Darwin) && OPENSWIFTUI_LINK_COREUI with an #else fallback, but this file is already wrapped in the same file-level #if, making the fallback unreachable. If this type is referenced from non-CoreUI builds, this move could also make the symbol unavailable—worth double-checking the conditional compilation intent here.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
==========================================
+ Coverage 27.16% 27.24% +0.07%
==========================================
Files 667 662 -5
Lines 42963 42448 -515
==========================================
- Hits 11671 11565 -106
+ Misses 31292 30883 -409 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
SwiftUI's original filenames (e.g.
Color+CGColor→CGColorConversions,ViewFactory→PlatformViewFactory,Signpost→Signposts)(e.g.
CommandsFlags→CommandFlag,RepeatAnimiation→RepeatAnimation)CoreUIDefaultSystemColorDefinitioncontent fromSystemColors.swiftto its correct dedicated file
.gitignoreand ID comments