Add code signing support for XCFrameworks#844
Merged
Conversation
🤖 Augment PR SummarySummary: This PR adds optional code-signing for the generated XCFramework artifacts during the release build. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
- Coverage 26.85% 26.85% -0.01%
==========================================
Files 671 671
Lines 43470 43470
==========================================
- Hits 11675 11672 -3
- Misses 31795 31798 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add a reusable codesign-xcframework action that imports a signing certificate and signs xcframeworks. Integrate it into the build and release workflows. Changes: - .github/actions/codesign-xcframework — new reusable composite action that sets up a CI keychain, imports a .p12 cert, trusts it for code signing, and signs xcframeworks - .github/actions/build-xcframework — call codesign action after build - .github/workflows/release.yml — pass signing secrets - .github/workflows/build_xcframework.yml — pass signing secrets The signing certificate (self-signed, "OpenSwiftUI") is stored as org-level GitHub secrets (SIGNING_CERTIFICATE_BASE_64 and SIGNING_CERTIFICATE_PASSWORD). Signing is gracefully skipped when secrets are not available.
1816363 to
a99f773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apple-actions/import-codesign-certs@v3Changes
Scripts/build_xcframework.sh— added signing step after xcframework creation.github/actions/build-xcframework/action.yml— added certificate import step and new inputs.github/workflows/release.yml— pass signing secrets to the composite actionSetup required
Add these GitHub repo secrets:
SIGNING_CERTIFICATE_BASE_64— base64-encoded.p12certificateSIGNING_CERTIFICATE_PASSWORD— password for the.p12fileTest plan
codesign -dv --verbose=4 OpenSwiftUI.xcframework