Enable OSUI ViewRenderer by default#872
Merged
Merged
Conversation
🤖 Augment PR SummarySummary: This PR makes OpenSwiftUI’s own view renderer the default, and treats the SwiftUI-backed renderer as an explicit opt-in path. Changes:
Technical Notes: Package settings now define 🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
+ Coverage 25.71% 27.06% +1.34%
==========================================
Files 677 678 +1
Lines 47008 47004 -4
==========================================
+ Hits 12090 12721 +631
+ Misses 34918 34283 -635 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dd9768e to
f0f9959
Compare
Member
Author
|
/uitest |
f0f9959 to
c79cea0
Compare
Member
Author
|
/uitest macos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent Summary
What Changed
OPENSWIFTUI_SWIFTUI_RENDERand defaulted it off for package builds.ViewRendererVendorso runtime code and tests can identify whether OpenSwiftUI or SwiftUI rendering is active.OPENSWIFTUI_SWIFTUI_RENDER=1is enabled.Why
The default integration path should not inherit SwiftUI renderer ABI restrictions. Those restrictions are only relevant when callers explicitly choose the SwiftUI renderer implementation.
Validation
OPENSWIFTUI_USE_LOCAL_DEPS=1 OPENSWIFTUI_SWIFTUI_RENDER=1 OPENATTRIBUTEGRAPH_OPENATTRIBUTESHIMS_ATTRIBUTEGRAPH=1 swift build --target OpenSwiftUICore