Skip to content

Fix privacy redaction screen capture handling#874

Merged
Kyle-Ye merged 1 commit into
mainfrom
feature/screen_capture_prohibited
May 24, 2026
Merged

Fix privacy redaction screen capture handling#874
Kyle-Ye merged 1 commit into
mainfrom
feature/screen_capture_prohibited

Conversation

@Kyle-Ye
Copy link
Copy Markdown
Member

@Kyle-Ye Kyle-Ye commented May 24, 2026

Summary

  • Treat PrivacyRedactionViewModifier as a primitive multi-view modifier to avoid materializing a Body == Never body.
  • Apply the screencaptureProhibited display-list property from the screen-capture redaction flag.
  • Hide scrapeable content when either privacy redaction is active or screen capture is prohibited.

@github-actions github-actions Bot added area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. area: view View APIs, modifiers, AnyView, ForEach, DynamicView, and related behavior. type: bug Something is not working correctly. labels May 24, 2026
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 24, 2026

🤖 Augment PR Summary

Summary: Updates PrivacyRedactionViewModifier to be a primitive multi-view modifier and fixes screen-capture handling.
Behavior: Propagates .screencaptureProhibited from redaction reasons and hides scrapeable content when either privacy redaction or screen-capture prohibition is active.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread Sources/OpenSwiftUICore/Data/EnvironmentKeys/PrivacyRedaction.swift
@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.98%. Comparing base (90b3f69) to head (da330b9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...UICore/Data/EnvironmentKeys/PrivacyRedaction.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
- Coverage   26.98%   26.98%   -0.01%     
==========================================
  Files         678      678              
  Lines       47149    47149              
==========================================
- Hits        12724    12723       -1     
- Misses      34425    34426       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 20e7dc3 into main May 24, 2026
6 of 7 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/screen_capture_prohibited branch May 24, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. area: view View APIs, modifiers, AnyView, ForEach, DynamicView, and related behavior. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant