Reduce amount of heap allocated types making it more secure#4
Merged
ba0f3 merged 1 commit intoOpenSystemsLab:masterfrom Sep 26, 2023
beef331:master
Merged
Reduce amount of heap allocated types making it more secure#4ba0f3 merged 1 commit intoOpenSystemsLab:masterfrom beef331:master
ba0f3 merged 1 commit intoOpenSystemsLab:masterfrom
beef331:master
Conversation
Contributor
|
Thank you! |
Contributor
Author
|
As mentioned in the comments we could look at using |
Contributor
|
That's greet, a PR is welcome. Thank you! |
Contributor
@beef331 - would it be possible to add the breaking changes in a changelog? Or in the release tag? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
ref objectas it's not needed and it just increases the chance of a heap attack. It also disables copies on the objects to prevent accidentally keeping the secret in memory at multiple places. Finally it bumps nimble versions and pins base32. This is a breaking change but hopefully for the better 😅