Conversation
revert operations interface since it would result in more changes in the container
fakepk
reviewed
Mar 25, 2019
| }; | ||
| // TODO we have to create a proper model for interface ressources delivered by the backend | ||
| return this.http.get<{ interfaces: Array<any> }>(serviceTemplateInstance._links['boundarydefinitions/interfaces'].href, httpOptions) | ||
| return this.http.get<InterfaceList>(serviceTemplateInstance._links['boundarydefinitions/interfaces'].href, httpOptions) |
Member
There was a problem hiding this comment.
Does this fix the todo in line 78? If so, delete todo.
Member
Author
There was a problem hiding this comment.
Unfortunately not. The container still creates a map of operations instead of a list.
The comment refers to lines 83-94.
lharzenetter
force-pushed
the
feature/multipleBuildPlans
branch
from
18a051a to
9087a91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
To support the execution of a specific termination or build plan, the user can now select the interface and operation he wants to execute.
Proposed Changes