Codechange: Detect and report crashes happening during regression #14774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
OpenTTD can crash during regression run but it can be very hard to reproduce if it only happens on CI for other OS than the one used by developer of a PR.
Description
Remove any crash file before running regression, then check no new crash happened.
If there was a crash, then output the crash log so there's at least a stacktrace to get some details.
Test run with
assert(false);Test run with
*(volatile uint8_t *)nullptr = 0;Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.