Skip to content

Codechange: let _dirkeys use an enum and EnumBitSet#15529

Merged
rubidium42 merged 1 commit intoOpenTTD:masterfrom
rubidium42:dirkeys-enum
Apr 25, 2026
Merged

Codechange: let _dirkeys use an enum and EnumBitSet#15529
rubidium42 merged 1 commit intoOpenTTD:masterfrom
rubidium42:dirkeys-enum

Conversation

@rubidium42
Copy link
Copy Markdown
Contributor

Motivation / Problem

Magic numbers used for _dirkeys.

Description

Move the magic numbers into an enum and EnumBitSet.

Limitations

Not actually tested on some platforms.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@rubidium42 rubidium42 marked this pull request as ready for review April 24, 2026 21:05
@rubidium42 rubidium42 merged commit 66df118 into OpenTTD:master Apr 25, 2026
18 checks passed
@rubidium42 rubidium42 deleted the dirkeys-enum branch April 25, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants