Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCleanup: Remove questionable syntax #7370
Conversation
Eddi-z
changed the title
This comment has been minimized.
This comment has been minimized.
|
That's some amazingly bad syntax. Is that from the dawn of time? |
Eddi-z
force-pushed the
Eddi-z:rating_calc
branch
2 times, most recently
from
a0b25ce
to
633bb92
This comment has been minimized.
This comment has been minimized.
|
i'm not 100% convinced that the track one is really the best/clearest approach to this
i'm fairly sure that's from r1. |
|
This looks like mixed code and data. I would use an array of score-boundaries and use std::lower_bound to figure out the offset of val. |
This comment has been minimized.
This comment has been minimized.
|
Yep, this dates back to r1: |
This comment has been minimized.
This comment has been minimized.
|
skipped the track one for now, as probably a more involved rewrite might be in order there |
Eddi-z commentedMar 12, 2019
No description provided.