Cleanup: Remove questionable syntax

[Eddi-z]

No description provided.

[nielsmh]

That's some amazingly bad syntax. Is that from the dawn of time?

[Eddi-z]

i'm not 100% convinced that the track one is really the best/clearest approach to this

That's some amazingly bad syntax. Is that from the dawn of time?

i'm fairly sure that's from r1.
and it probably makes perfect sense if you're reading assembler code and translating that into C code. but if you're reading this with an "if X then do Y" mindset, the conditions are all backwards and confusing.

[M3Henry]

This looks like mixed code and data. I would use an array of score-boundaries and use std::lower_bound to figure out the offset of val.

[nielsmh]

Yep, this dates back to r1:
https://github.com/OpenTTD/OpenTTD/blame/2c27f45cdc31c0466d72eb8d1539448b93af0d5b/economy.c#L56-L60

[Eddi-z]

skipped the track one for now, as probably a more involved rewrite might be in order there