Add: save openttd.cfg immediately on changing a setting#8358
Merged
TrueBrain merged 1 commit intoOpenTTD:masterfrom Dec 13, 2020
Merged
Add: save openttd.cfg immediately on changing a setting#8358TrueBrain merged 1 commit intoOpenTTD:masterfrom
TrueBrain merged 1 commit intoOpenTTD:masterfrom
Conversation
TrueBrain
force-pushed
the
save_config_more_often
branch
from
1a9cbef to
6b40f56
Compare
9 tasks
Member
|
There is a command line option "-x = Do not automatically save to config file on exit". I would have expected that to somehow affect this. |
Formally it was only done on exit. This means that if it crashes changes in settings were not stored. This is often rather frustrating. Additionally, targets (like emscripten) where people are unlike to use "Exit Game", will never see their configuration stored. The drawback is that on every setting change there is some minor I/O of writing the ini file to disk again.
TrueBrain
force-pushed
the
save_config_more_often
branch
from
6b40f56 to
5016e6e
Compare
frosch123
reviewed
Dec 13, 2020
frosch123
approved these changes
Dec 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formally it was only done on exit. This means that if it crashes
changes in settings were not stored. This is often rather
frustrating. Additionally, targets (like emscripten) where people
are unlike to use "Exit Game", will never see their configuration
stored.
The drawback is that on every setting change there is some minor
I/O of writing the ini file to disk again.