Skip to content

Item IDs aren't checked for capitalisation #427

@nemethviktor

Description

@nemethviktor

A little more context on discord https://discord.com/channels/142724111502802944/337701432230805505/1506201143842181260 but basically if I define the ID list as

// Unit Wagons (Rail), available ID range: 13000-13001 (hex 0x32C8..0x32C9)
#define ID_RANGE_UNIT_WAGONS_RAIL 0x32C8..0x32C9
item(FEAT_TRAINS, item_mu_MU_Wagon_Unpowered, 13000) {}
item(FEAT_TRAINS, item_mu_MU_Wagon_Powered, 13001) {}

note non-lowercase above

but then define the individual item lowercase

item(FEAT_TRAINS, item_mu_mu_wagon_unpowered) {
    property {
        name: string(str_mu_mu_wagon_unpowered);
        

then the nml will compile without error but will cause silent failures in switches that depend on vehicle ids such as attachment rules.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions