Codechange: Change Ply and Pillow import statements #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
Jan 1, 2026
ingstem
force-pushed
the
codechange-version-info
branch
from
9e7d359 to
6e79a70
Compare
- Change to using nml.ply instead of .ply in import statements - Change imports to only import __version__ - Change Pillow import to be similar to new fixed Ply import - Fix Ply import not using __version__ from bundled Ply
ingstem
force-pushed
the
codechange-version-info
branch
from
6e79a70 to
7c657cf
Compare
ingstem
changed the title
LordAro
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when running nmlc --version that Ply version information was missing, or gave the wrong version, as it was still trying to import the installed package, not the locally bundled package.
nmlc --version now returns the correct Ply version:
Library versions encountered:
PIL: 12.0.0
PLY: 2022.10.27
This was primarily to fix the Ply version check, but I also did some minor modifications to the Pillow import clause, so that both Pillow and Ply imports and checks are similar.