[0.6.x] Show max recorded position in the Tablet Debugger.#3427
Merged
Conversation
jamesbt365
added
the
desktop
gonX
added
the
needs-forward-port
gonX
reviewed
Dec 3, 2024
Member
gonX
left a comment
gonX
left a comment
There was a problem hiding this comment.
Looks okay:
...until you get a fat tablet debugger parse and lines get hidden:
This is more of an issue with the tablet debugger window itself since fat parses could already do that, now it's just more apparent because a bunch of lines were stolen by this feature.
We should fix so that the tablet debugger reflows that stack above the fold, though probably not in this PR. But the feature works and the code LGTM, just want to hear what other people think based off of this.
gonX
removed
the
needs-forward-port
Member
|
Not too worried about the debugger info getting cut off. Users can always extend the debugger window. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry if anything including naming convention is off, this is my first time touching C# let alone this project, please mention anything and I'll do my best to get things inline with current choices.
This pull requests currently targets
0.6.x. I have noticed thatmasteris a bit stalled right now and the entire UI is being replaced with #2772, so I won't be submitting an obsolete PR.I wasn't really sure what to title the new
StackLayoutItemso the name right now is a bit redundant, but its also the only bit of data that currently benefits from having a field that shows the max.I also thought about adding a button to reset the data, but considering switching tablet on the same debugger instance is an unusual scenario when using this feature, as typically the only reason to use it would be to support a new tablet? So I've not included one at this time.
Let me know on any changes or nitpicks, I'm not sure if I missed anything for this project and I'd rather not add any additional overhead from me trying to snipe some easy issues.
Fixes #2433 but solely on
0.6.x.