Only clamp width and height in Lock to usable area if rotation is 0 or 180#3815
Merged
Merged
Conversation
gonX
requested changes
May 4, 2025
Member
gonX
left a comment
gonX
left a comment
There was a problem hiding this comment.
This is just different from current behavior. I would prefer something that considers rotation, but I realize the general rotation handling isn't great either.
Rotating e.g. 45 degrees does not constrain the area properly even when moving around.
Member
|
After further discussion on Discord the PR should instead disable the behavior on non-symmetric rotations, e.g. if rotation is 0 or 180, clamp dimensions, otherwise do not clamp. /e: for further explanation, fixing this properly in Eto does not seem easy. Better to push for Avalonia unless someone else wants to look at fixing it properly. |
Kuuuube
force-pushed
the
lock-usable-area-fix
branch
from
c1c0256 to
5db459d
Compare
Kuuuube
changed the title
Lock to usable area if rotation is 0 or 180
Kuuuube
force-pushed
the
lock-usable-area-fix
branch
from
5db459d to
ad87e48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These make it annoying for users that rotate their area in some cases. Eg. #3811
In theory we could implement a way to shrink the area by exactly how much is needed to fit inside the tablet's usable area for any given rotation. But this feels really strange in practice like I'm fighting OTD to set the area and it's "randomly" changing things that weren't intended to be changed. So I think it's better to just let the user figure it out themselves.
The important thing with
Lock to usable areais that users can easily set their area offsets exactly to the edges.