[06x] Handle termination signals in Daemon#3992
Merged
Merged
Conversation
SIGINT/SIGTERM/SIGHUP etc would cause the daemon to not properly clean up the named pipes, causing issues on multi-user Linux systems. This commit uses a cancelation token to instruct the daemon to abort taking further connections, and then the handler waits for the daemon to finish
gonX
added
enhancement
gonX
commented
Aug 18, 2025
Comment on lines
+163
to
+165
| // ReSharper disable once LoopVariableIsNeverChangedInsideLoop | ||
| // ReSharper disable once AccessToModifiedClosure | ||
| while (daemonRunning) |
Member
Author
There was a problem hiding this comment.
please review these lines carefully, daemonRunning is modified outside of the function and I am not sure of the best approach here
AkiSakurai
reviewed
Sep 1, 2025
Should allow shutdowns with connected clients Co-authored-by: Aki Sakurai <75532970+AkiSakurai@users.noreply.github.com>
5 tasks
Kuuuube
approved these changes
Dec 4, 2025
Member
Kuuuube
left a comment
Kuuuube
left a comment
There was a problem hiding this comment.
Looks good. Works. Does the UX need this too? It leaves behind a pipe.
Member
Author
|
Oh, yes, the UX actually does need this too. I think this also needs testing with our osu-framework integration. |
gonX
changed the title
This was referenced Dec 6, 2025
3 tasks
This was referenced Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIGINT/SIGTERM/SIGHUP etc would cause the daemon to not properly clean up the named pipes, causing issues on multi-user Linux systems.
This commit uses a cancellation token to instruct the daemon to abort taking further connections, and then the handler waits for the daemon to finish
Fixes #3804
I recommend reviewing the diff with "ignore whitespace" enabled.