Skip to content

[0.6.x] Report potential driver detection false positives and show process name and filename in log#4188

Merged
gonX merged 5 commits into
OpenTabletDriver:0.6.xfrom
Kuuuube:better-driver-detection
Oct 5, 2025
Merged

[0.6.x] Report potential driver detection false positives and show process name and filename in log#4188
gonX merged 5 commits into
OpenTabletDriver:0.6.xfrom
Kuuuube:better-driver-detection

Conversation

@Kuuuube
Copy link
Copy Markdown
Member

@Kuuuube Kuuuube commented Oct 4, 2025

Example logs:

[Detect:Warning]	'XP-Pen' driver is detected. Processes found: [XPPenTablet: C:\Program Files\XPPen\XPPenTablet.exe]. If any problems arise, visit 'https://opentabletdriver.net/Wiki/FAQ/Windows'.
[Detect:Warning]        'XP-Pen' driver is detected. It may be a false positive. Processes found: [XPPenTablet: C:\Program Files\XPPen\XPPenTablet.exe, OpenTabletDriver.Daemon: C:\Users\testuser\Desktop\OpenTabletDriver\bin\OpenTabletDriver.Daemon.exe]. If any problems arise, visit 'https://opentabletdriver.net/Wiki/FAQ/Windows'.

Both ProcessName and MainModule?.FileName can error on accessing them. Although ProcessName erroring seems unlikely. MainModule?.FileName includes the full absolute filepath for the running process not just the filename.

@github-actions github-actions Bot added daemon Affects the driver itself core OpenTabletDriver core library labels Oct 4, 2025
@Kuuuube Kuuuube added this to the v0.6.7 milestone Oct 4, 2025
Copy link
Copy Markdown
Member

@gonX gonX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor styling issue

Comment thread OpenTabletDriver.Daemon/DriverDaemon.cs Outdated
Copy link
Copy Markdown
Member

@gonX gonX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gonX gonX merged commit 9e998ad into OpenTabletDriver:0.6.x Oct 5, 2025
12 checks passed
@gonX gonX modified the milestones: v0.6.7, v0.6.6.1 Oct 5, 2025
@gonX gonX mentioned this pull request Oct 13, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core OpenTabletDriver core library daemon Affects the driver itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants