[0.6.x] add OutOfRangeReport for IntuosReportParser#4240
Conversation
This has been tested on the CTL-472. All supported models except CTE-460, when using the IntuosReportParser configuration, end up calling wacom_bpt_pen in the Linux kernel driver. https://github.com/linuxwacom/input-wacom/blob/53081c21d26eee390020990087601afd8fdf2c92/4.18/wacom_wac.c#L3208 https://github.com/linuxwacom/input-wacom/blob/53081c21d26eee390020990087601afd8fdf2c92/4.18/wacom_wac.c#L3559 The CTE-460 might have an incorrect parser.
github-actions
Bot
added
the
configuration
Considering CTE-660 is running BambooReportParser and there is proper verification that it's the correct parser for the CTE-660 I think it's reasonable to assume that the CTE-460 should also use this parser. CTE-460 is such a rare tablet it wouldn't be surprising if nobody has tested it (or cared to report it doesn't work) in years. I'm sure the CTE-460 did work initially when it was added but it probably didn't ever get tested for the split off to BambooReportParser like other tablets were. |
|
This parser is currently used in the following tablet configurations, and will be affected by this change:
|
gonX
left a comment
gonX
left a comment
There was a problem hiding this comment.
LGTM assuming this works. Do we want more testers for other tablets on this before merging, or is merging testing? I can't imagine we're doing a new release with this for another couple of weeks.
Kuuuube
left a comment
Kuuuube
left a comment
There was a problem hiding this comment.
Tested and working on:
CTL-472, CTL-471, CTL-470, CTH-461, CTL-460
Not detecting out of range but does not break anything:
ET-0405-U
Probably safe to assume this also doesnt detect anything for the FT-0405-U.
3 participants
This has been tested on the CTL-472.
All supported models except CTE-460, when using the IntuosReportParser configuration, end up calling wacom_bpt_pen in the Linux kernel driver.
https://github.com/linuxwacom/input-wacom/blob/53081c21d26eee390020990087601afd8fdf2c92/4.18/wacom_wac.c#L3208
https://github.com/linuxwacom/input-wacom/blob/53081c21d26eee390020990087601afd8fdf2c92/4.18/wacom_wac.c#L3559
The CTE-460 might have an incorrect parser.