Add identifier to XP-Pen Deco 01 V2 and fix misdetect#4293
Merged
Conversation
github-actions
Bot
added
the
configuration
Member
|
This seems very annoying to review. We can YOLO approve it and hope that we start fixing detection for variants in another way soon? |
Member
Author
|
I don't thing theres realistically any way to be sure that this isnt breaking. The firmware for this tablet is insane. To properly support it we'd probably need a list of all firmware versions from xp pen. If i find new variants of this i might have to make a script to check off of the diags and strings we already have to ensure it doesnt change anything. It's getting ridiculous with how many variants there are. |
This was referenced Dec 5, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First variant (3063fd8, fae5df5):
Verification: https://discord.com/channels/615607687467761684/615611007951306863/1437597023422386267
Specs check: https://discord.com/channels/615607687467761684/615611007951306863/1437589269337083956
Diag: diag.json
Strings: dump.txt
Strings for the other two variants I've had to add them for to avoid a misdetect are in #4102 and #1936 (dump.txt).
This may be a breaking change considering theres already 6 identifiers for this tablet supported we may be supporting some variants without knowing it. But this shouldn't cause any issues for all variants we are aware of.
Second variant (a543ecd):
Verification: https://discord.com/channels/615607687467761684/615611007951306863/1441590993219747891
Specs check: https://discord.com/channels/615607687467761684/615611007951306863/1441596543474864230
Diag: dignostic.json
Strings: string dump.txt