Fix various problems and override specific framework errors.#26
Merged
InfinityGhost merged 2 commits intoOpenTabletDriver:masterfrom Mar 11, 2024
Merged
Fix various problems and override specific framework errors.#26InfinityGhost merged 2 commits intoOpenTabletDriver:masterfrom
InfinityGhost merged 2 commits intoOpenTabletDriver:masterfrom
Conversation
InfinityGhost
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
second time around hopefully things are better now.
Everything I mention below should get an answer because I can't read minds.
Do we consider this to fix #8 (not the best solution, but it does block things that fall under the regex but do not match a repository)
With the addition of repo tokens it is now "harder" to have a proper solution. I could add support for everything but whitespace & "#" and it'll basically eliminate the problem in 100% of all situations, but the current solution will basically work in 99.5% of situations. The only problem in #8 is that links with #num at the end get caught but characters that are matched by the regex are before that and therefore the issue is gone.
Due to the addition of a button to remove issue responses, I have allowed single digit matching again so you no longer have to put 08 to link an issue with a single digit id, I have no idea if this is wanted.