[OT-253][FEAT]: JPQL사용에 따른 영속성 컨텍스트 오류 수정#144
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughKakao 기존 사용자의 프로필 업데이트 및 reactivation 로직을 제거하고, 회원 탈퇴 경로를 개별 감소 연산에서 JPQL 기반 벌크 소프트 삭제로 대체하며 관련 리포지토 메서드와 Member 엔티티의 일부 public 메서드를 제거/추가했습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant MemberService as MemberService
participant BookmarkRepo as BookmarkRepository
participant LikesRepo as LikesRepository
participant PreferredTagRepo as PreferredTagRepository
participant MemberRepo as MemberRepository
Client->>MemberService: 회원 탈퇴 요청(with memberId)
MemberService->>BookmarkRepo: softDeleteAllByMemberId(memberId)
MemberService->>LikesRepo: softDeleteAllByMemberId(memberId)
MemberService->>PreferredTagRepo: deleteAllByMember(member)
MemberService->>MemberRepo: softDeleteByMemberId(memberId)
MemberRepo-->>MemberService: 성공 응답
MemberService-->>Client: 탈퇴 완료 응답
sequenceDiagram
participant Client
participant KakaoAuth as KakaoAuthService
participant MemberRepo as MemberRepository
participant RadarPrefService as RadarPreferenceService
Client->>KakaoAuth: 카카오 로그인/회원 조회 요청
KakaoAuth->>MemberRepo: findByProviderId(...)
alt 기존 회원
KakaoAuth->>RadarPrefService: reactivateRadarPreference(existingMember)
KakaoAuth-->>Client: existingMember 반환 (프로필/재활성화 미적용)
else 신규 회원
KakaoAuth->>MemberRepo: save(newMember)
KakaoAuth-->>Client: newMember 반환
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
📷 스크린샷
☑️ 체크 리스트
#️⃣ 연관된 이슈
close #140
💬 리뷰 요구사항
Summary by CodeRabbit
릴리스 노트
Bug Fixes
Refactor