[OT-294] [FIX]: 숏폼 디테일 originId 및 originMediaType 추가#161
Merged
Conversation
WalkthroughShortFormDetailResponse 레코드에 originId(Long)와 originType(MediaType) 필드를 추가하고, 이를 매퍼와 서비스 로직으로 전달하도록 BackOfficeShortFormMapper 및 BackOfficeShortFormService를 수정했습니다. 또한 CORS 허용 출처를 변경했습니다. Changes
Sequence Diagram(s)(생성 조건 미충족 — 생략) Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 분 Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@apps/api-admin/src/main/java/com/ott/api_admin/shortform/dto/response/ShortFormDetailResponse.java`:
- Around line 28-32: The response record currently exposes the field name
originType (record component originType) causing JSON to contain originType
instead of the contracted originMediaType; rename the record component
originType to originMediaType in ShortFormDetailResponse (and update its `@Schema`
to match) and then update any mappers, DTO builders, service method parameters
and usages that reference originType to use originMediaType so the serialized
JSON and all call sites remain consistent with the API contract.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 0b77faa1-7c5d-48f6-8a1d-c53de2fed5e2
📒 Files selected for processing (3)
apps/api-admin/src/main/java/com/ott/api_admin/shortform/dto/response/ShortFormDetailResponse.javaapps/api-admin/src/main/java/com/ott/api_admin/shortform/mapper/BackOfficeShortFormMapper.javaapps/api-admin/src/main/java/com/ott/api_admin/shortform/service/BackOfficeShortFormService.java
yubin012
approved these changes
Mar 12, 2026
Contributor
|
확인했씁니다~~~~ |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/api-admin/src/main/java/com/ott/api_admin/config/SecurityConfig.java (1)
48-68: permitAll 목록에 중복 항목이 있습니다.다음 경로들이 중복으로 정의되어 있습니다:
/back-office/swagger-ui/**(lines 56, 63)/back-office/v3/api-docs/**(lines 58, 64)/back-office/swagger-resources/**(lines 59, 65)기능에는 영향이 없지만, 유지보수성을 위해 중복 제거를 권장합니다.
♻️ 중복 제거 제안
.requestMatchers( "/actuator/health/**", "/actuator/info", "/actuator/prometheus", "/actuator/prometheus/**", "/back-office/login", "/back-office/reissue", "/back-office/swagger-ui.html", "/back-office/swagger-ui/**", "/back-office/v3/api-docs", "/back-office/v3/api-docs/**", "/back-office/swagger-resources/**", "/swagger-ui/**", "/v3/api-docs/**", - "/swagger-resources/**", - "/back-office/swagger-ui/**", - "/back-office/v3/api-docs/**", - "/back-office/swagger-resources/**" - - + "/swagger-resources/**" ).permitAll()🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/api-admin/src/main/java/com/ott/api_admin/config/SecurityConfig.java` around lines 48 - 68, In SecurityConfig, the requestMatchers(...) call passed to permitAll() contains duplicate path entries; remove the repeated occurrences of "/back-office/swagger-ui/**", "/back-office/v3/api-docs/**", and "/back-office/swagger-resources/**" from the list so each path appears only once (update the array/list inside the requestMatchers(...) invocation used before .permitAll()).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/api-admin/src/main/java/com/ott/api_admin/config/SecurityConfig.java`:
- Around line 48-68: In SecurityConfig, the requestMatchers(...) call passed to
permitAll() contains duplicate path entries; remove the repeated occurrences of
"/back-office/swagger-ui/**", "/back-office/v3/api-docs/**", and
"/back-office/swagger-resources/**" from the list so each path appears only once
(update the array/list inside the requestMatchers(...) invocation used before
.permitAll()).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2e9f92f8-535a-4b78-afc1-c872a5467c68
📒 Files selected for processing (1)
apps/api-admin/src/main/java/com/ott/api_admin/config/SecurityConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
☑️ 체크 리스트
#️⃣ 연관된 이슈
Summary by CodeRabbit