Skip to content
This repository was archived by the owner on Aug 24, 2025. It is now read-only.

Day / night mode#417

Merged
dennisguse merged 27 commits into
mainfrom
dayNightTheme#231
Sep 23, 2020
Merged

Day / night mode#417
dennisguse merged 27 commits into
mainfrom
dayNightTheme#231

Conversation

@dennisguse
Copy link
Copy Markdown
Member

@dennisguse dennisguse commented Sep 6, 2020

Slowly implementing day/night mode.

This will include:

  • migration to app compat themes
  • app-wide configuration settings (default: night)
  • tinting all icons properly
  • cleaning up themes (this will also fix that the color of the search icon is different)
  • move to material design components: https://material.io/develop/android/components/text-fields
  • make activity spinner look nice
  • charts
  • set day background for trackController (later)

This PR changes the UI just by theming for day/night mode.
From my perspective some things do not yet look as polished as they were others are better.
What I don't like yet is the spinner styling (e.g., activity selector), but it saves us a lot of headaches not styling it :)

Fixes #231.

PS: I just found out that I toggle day/night mode easily on my LineageOS phone ;)

@dennisguse dennisguse added the enhancement New feature or request label Sep 6, 2020
@dennisguse dennisguse force-pushed the dayNightTheme#231 branch 3 times, most recently from e1edaa8 to 26ac4af Compare September 15, 2020 19:30
@dennisguse dennisguse requested review from pstorch and rgmf September 15, 2020 19:33
@dennisguse dennisguse marked this pull request as ready for review September 15, 2020 19:33
@dennisguse
Copy link
Copy Markdown
Member Author

@thrillfall What do you think?

Copy link
Copy Markdown
Member

@rgmf rgmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. I like it.

@pstorch
Copy link
Copy Markdown
Member

pstorch commented Sep 16, 2020

Only a few minor remarks:
The font is bigger now in the track list activity, so 1 track item less fits on the screen. Too big I opinion.
And the start/stop buttons have black background in day mode (I see you want to do this later).
The exclamation mark icon when deleting a track is too light in day mode, I think.

@dennisguse
Copy link
Copy Markdown
Member Author

Thanks for testing and the feedback.
Almost done.

About the start/stop background: also yes.
The icons have a transparent background and this looks awkward on a bright background.
And my color selection skills are basically zero, but I will try something less bright.
Suggestions welcome.

PS: The delete dialog background also does not fit to the dark style - it is too dark compared to the preference dialogs.
Don't yet why.

@dennisguse
Copy link
Copy Markdown
Member Author

The AlertDialog needs to be Androidx - that fixes the dark background color styling.

@dennisguse
Copy link
Copy Markdown
Member Author

@kylecorry31 This PR implements day/night mode for OpenTracks.
Technically Trail-Sense and OpenTracks will look very much alike as both apps use almost the default color codes :)
Major difference is that our orange is slightly different (FF8800 vs FF6D00), but Trail-Sense's orange (from my perspective) fits better to the day theme.
Long story short: do you have any trouble, if we use the same for day/night in OpenTracks?

@kylecorry31
Copy link
Copy Markdown

No problem at all!

@dennisguse dennisguse merged commit e574c67 into main Sep 23, 2020
@dennisguse dennisguse deleted the dayNightTheme#231 branch September 23, 2020 05:36
@dennisguse dennisguse mentioned this pull request Sep 23, 2020
2 tasks
@dennisguse
Copy link
Copy Markdown
Member Author

@kylecorry31 I tested this some days ago and then the colorAccent does not fit anymore with the logo. So, I guess we need something in the middle.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Theming support day/night

4 participants