feat(mipush): handle missing key by environment mode & update README run instructions#16
Merged
w568w merged 2 commits intoOpenTreeHole:mainfrom Nov 1, 2025
Merged
Conversation
- Added section on how to export MODE and BASE_PATH before running - Clarified available modes: production / dev / test / perf Signed-off-by: acture <acturea@gmail.com>
Refactor `getMipushKey()` to behave differently across environments: - In production: fatal on missing key. - In dev/test: warn and continue with empty key. - In perf: use mock key. - Default: fatal for unknown mode. This prevents non-production environments from crashing when the Mipush key is not present, while preserving strict validation in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 Summary
This PR introduces environment-aware behavior for the Mipush key initialization
and updates the documentation to reflect the new MODE settings.
Code changes
Documentation changes
🎯 Motivation
Previously, missing push-key files caused startup failure even in development or testing environments.
This PR makes startup behavior mode-aware and updates the README to help contributors understand and use these modes correctly.