Skip to content

Bulk Uploader Styling#1803

Merged
ctaylo37 merged 3 commits intoOpenTreeMap:masterfrom
ctaylo37:Importer-Styling
Nov 19, 2014
Merged

Bulk Uploader Styling#1803
ctaylo37 merged 3 commits intoOpenTreeMap:masterfrom
ctaylo37:Importer-Styling

Conversation

@ctaylo37
Copy link
Contributor

-Styled bulk uploader screens.
-Styled photo review pagination to match bulk uploader & comment
moderation pagination buttons.

-Styled bulk uploader screens.
-Styled photo review pagination to match bulk uploader & comment
moderation pagination buttons.
@maurizi
Copy link
Contributor

maurizi commented Nov 19, 2014

I can't help but notice that the pagination styling is (almost) completely identical in both places.

Unless there is good reason not to, I think we should pull it out into it's own file and include it in both places. Perhaps as a mixin? I know there are ways to reuse styling with SCSS, though I'm not an expert on which ones are most appropriate to which situations.

@ctaylo37
Copy link
Contributor Author

It really should be a global style. Let me look into this.

-Added the pagination styling to _layout.scss to be used anywhere
inside of the container.
@ctaylo37
Copy link
Contributor Author

I moved it to _layout.scss. So it's not a mixin, but will be applied to all pagination within the container element.

@maurizi
Copy link
Contributor

maurizi commented Nov 19, 2014

@ctaylo37 Should this section from _moderation.css be removed as well?

@ctaylo37
Copy link
Contributor Author

Ahhh. Yes it should. I will remove.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) when pulling 2fbe6f4 on ctaylo37:Importer-Styling into 7fbd9fc on OpenTreeMap:master.

@maurizi
Copy link
Contributor

maurizi commented Nov 19, 2014

+1

ctaylo37 pushed a commit that referenced this pull request Nov 19, 2014
@ctaylo37 ctaylo37 merged commit 51e8c53 into OpenTreeMap:master Nov 19, 2014
@ctaylo37 ctaylo37 deleted the Importer-Styling branch November 19, 2014 16:29
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) when pulling 4017c80 on ctaylo37:Importer-Styling into 7fbd9fc on OpenTreeMap:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants