Merged
Conversation
-Styled bulk uploader screens. -Styled photo review pagination to match bulk uploader & comment moderation pagination buttons.
Contributor
|
I can't help but notice that the pagination styling is (almost) completely identical in both places. Unless there is good reason not to, I think we should pull it out into it's own file and include it in both places. Perhaps as a mixin? I know there are ways to reuse styling with SCSS, though I'm not an expert on which ones are most appropriate to which situations. |
Contributor
Author
|
It really should be a global style. Let me look into this. |
-Added the pagination styling to _layout.scss to be used anywhere inside of the container.
Contributor
Author
|
I moved it to _layout.scss. So it's not a mixin, but will be applied to all pagination within the container element. |
Contributor
|
@ctaylo37 Should this section from |
Contributor
Author
|
Ahhh. Yes it should. I will remove. |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Styled bulk uploader screens.
-Styled photo review pagination to match bulk uploader & comment
moderation pagination buttons.