Return plot create/update validation errors with a 400 status#3202
Merged
jwalgran merged 1 commit intoOpenTreeMap:developfrom Aug 31, 2017
Merged
Conversation
Previously, validation errors in the plot create and update views were not being caught, resulting in a 500 error being logged in Rollbar. Updating these views to properly handle the validation errors required a fix to the `transform_plot_update_dict` function to check for the existence of a key before trying to read it from the plot dict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, validation errors in the plot create and update views were not being
caught, resulting in a 500 error being logged in Rollbar.
Updating these views to properly handle the validation errors required a fix to
the
transform_plot_update_dictfunction to check for the existence of a keybefore trying to read it from the plot dict.
Testing
Use a mobile app and attempt to both create and update a tree with zero diameter and verify that the API response has a 400 status code.
Connects to OpenTreeMap/otm-ios#353