Remove filters from map tap nearby plot request#279
Merged
jwalgran merged 1 commit intoOpenTreeMap:masterfrom Feb 23, 2016
Merged
Conversation
The /location/lat,lng/plots API endpoint ignores any filters that are passed along with the request: https://github.com/OpenTreeMap/otm-core/blob/983ffcdb0a226fc9bd6ab1fc3e3f42e47ed9e5ba/opentreemap/api/plots.py#L39 The filters have been ignored since the initial creation of the OTM2 API endpoint. OpenTreeMap/otm-core@b25c3b9
Contributor
|
+1, tested. Good sleuthing. |
jwalgran
added a commit
that referenced
this pull request
Feb 23, 2016
…en-finding-plot Remove filters from map tap nearby plot request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /location/lat,lng/plots API endpoint ignores any filters that are passed along with the request:
https://github.com/OpenTreeMap/otm-core/blob/983ffcdb0a226fc9bd6ab1fc3e3f42e47ed9e5ba/opentreemap/api/plots.py#L39
The filters have been ignored since the initial creation of the OTM2 API endpoint.
OpenTreeMap/otm-core@b25c3b9
Testing
If you run the application in the simulator, apply a filter, and then tap the map, you should see in the NSLog output that the request is sent without a
q=parameter.The specific bug resolved by this commit can be tested for by following the reproduction steps from #278:
On the website:
On the iOS app:
On the current
masterbranch, the popup will not appear because the filters passed along to the endpoint are not encoded using a method consistent with what the server expects, resulting in a 400 response.Connects to #278