In tree save/edit, post only writable fields#285
Merged
RickMohr merged 1 commit intoOpenTreeMap:masterfrom Mar 7, 2016
RickMohr:post-only-writable-fields
Merged
In tree save/edit, post only writable fields#285RickMohr merged 1 commit intoOpenTreeMap:masterfrom RickMohr:post-only-writable-fields
RickMohr merged 1 commit intoOpenTreeMap:masterfrom
RickMohr:post-only-writable-fields
Conversation
| NSMutableDictionary *writableData = [[NSMutableDictionary alloc] init]; | ||
| NSDictionary *fieldData = [[OTMEnvironment sharedEnvironment] fieldData]; | ||
|
|
||
| for (NSString *model in [NSArray arrayWithObjects:@"plot", @"tree", nil]) { |
Contributor
There was a problem hiding this comment.
This can be shortened with an array literal
for (NSString *model in @[@"plot", @"tree"]) {
Contributor
|
I recreated the "public user can't save a photo" error on the When logged in as a privileged user I was still able to save edits to all fields including stewardship and alerts. Nice implementation. 👍 |
Connects #263 Testing: * Make an instance whose `public` role can upload photos but nothing else * Verify that a `public` user can upload an image * Verify that an admin user can still create and edit trees
RickMohr
added a commit
that referenced
this pull request
Mar 7, 2016
In tree save/edit, post only writable fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects #263
Testing:
publicrole can upload photos but nothing elsepublicuser can upload an image