Change property attributes on OTMPreferences#325
Merged
jwalgran merged 1 commit intoOpenTreeMap:masterfrom Oct 20, 2016
Merged
Conversation
The app was crashing with an `EXC_BAD_ACCESS` exception when the app delegate's `applicationDidEnterBackground:` method attempted to call `save` on `OTMPreferences`. Setting a breakpoint on unhandled exceptions revealed that the value of the `instance` property was invalid. It looks like this is the result of using the `assign` attribute, which should only be used on primitive types (int, BOOL, etc.). I am not able to reproduce the exception after replacing `assign` with our app-wide convention for string properties, `nonatomic` and `strong`.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app was crashing with an
EXC_BAD_ACCESSexception when the app delegate'sapplicationDidEnterBackground:method attempted to callsaveonOTMPreferences. Setting a breakpoint on unhandled exceptions revealed that the value of theinstanceproperty was invalid. It looks like this is the result of using theassignattribute, which should only be used on primitive types (int, BOOL, etc.).I am not able to reproduce the exception after replacing
assignwith our app-wide convention for string properties,nonatomicandstrong.Testing
Follow the reproduction steps in #323.
Connects to #323