Source Code page and references to script/lib

[supahgreg]

The "Source Code" page does not have the script page header, making identification and navigation trickier than it should be. As a user I'd like the Source Code page to share the layout of other script- or lib-related pages.

[sizzlemctwizzle]

+1 for putting the script page header on the source code page

Edit: Also, nice to see a Scriptish dev here. Welcome aboard.

[jerone]

I tried to fix this issue (noticed this too), but I have to completely rewrite the whole function user>editScript.

I'm thinking of separting the 'view source' and 'edit source' logic. Any reasons why this has been combined without any addition info like in script>view function?

[Zren]

I'm thinking of separating the 'view source' and 'edit source' logic. Any reasons why this has been combined without any addition info like in script>view function?

Nope. It's currently used as the scriptViewSourcePage, scriptEditSourcePage, and userWriteNewScriptPage.

scriptViewSourcePage/scriptEditSourcePage could possibly share a template, or they could share includes. userWriteNewScriptPage shouldn't have the script header though, so it needs it's own template.

[Martii]

@jerone first and @Zren second,
Would you scoot any of your above relevant comments over to #169 please... this should be better to isolate the issues so they can be worked on independently and one step at time... we are live remember. Occasionally we will have ideas at nearly the same time and best to keep them historically tracked as cleanly as possible. Thanks. :)

---

+1 for putting the script page header on the source code page

Specific to this issue topic +1 here.

[Martii]

completely rewrite the whole function user>editScript.

In regards to this just noticed the current route is marked as Legacy and to be removed in app.js from ec278a9 which is a little odd to put that in on a commit to be removed later. If the code is just going to be dumped there isn't much of a point to keep this on non-later status... labeling as later.