Allow username change

[sizzlemctwizzle]

Allow users to choose another unclaimed name.

Also, we should probably prevent users from registering with an email address as their username. A simple regex can catch this and we could display a message saying the their username will be display publicly.

[Martii]

Perhaps one time only? I'd rather not see a bazillion changes... great for spammers.

registering with an email address as their username

+1 ... was thinking about putting a mesage in on the login page but this idea sounds much better... should filter out anything that resembles a web url too.

[sizzlemctwizzle]

Yeah we'll give them one chance to change it.

[Zren]

We can't serialize the username anywhere then. We would need to only store the script.owner = user._id and use scriptQuery.populate('owner', 'name').

[sizzlemctwizzle]

We can't serialize the username anywhere then.

What do you mean? We'll obviously have to change the username in DB everywhere it appears.

[Martii]

change the username in DB everywhere it appears.

I'm seeing a potential DB label here from this statement with some minimal implied CODE labeling... I think @Zren might be wondering if this should be handled purely in ECMAScript and have the DB store/access a token that represents the username. Either way works but depends on how much DB work, @sizzlemctwizzle, you want to have with this... with a one time only change a DB oriented "fix" might be the better option but we'll need a flag on their account info saying it's already been changed I think.

[sizzlemctwizzle]

with a one time only change a DB oriented "fix" might be the better option

Yes this is the way to go imo. If you're dealing with core data (username is about as "core" as it gets) you should be doing it in the DB.

[joeytwiddle]

One change only seems a bit limited. How about one change per year? 😃

Er ... good luck with the DB fix!

(FWIW in general I think DB records should use the user ID, not the username, to refer to users, although admittedly this does mean the overhead of an extra lookup to resolve the username from the ID every time you need it.)

[Martii]

One change only seems a bit limited. How about one change per year?

LOL... Once is plenty... if someone can't make up their mind on who they are... well there's a place for that. ;)

So -1 not to mention it will clutter up the DB with changes and tracking. Pick an identity nickname and stick with it, with one optional approved change for those who accidentally used something they shouldn't have.

---

btw @joeytwiddle see https://openuserjs.org/scripts/joeytwiddle/Github_Notifications_Dropdown/issues/SUGGESTIONS

[Lorentz83]

+1
I registered myself using my github account, but OpenUserJS instead of display my github name shows my email.
I'd like to keep it more private to prevent spam.

[Martii]

I registered myself using my github account, but OpenUserJS instead of display my github name shows my email.

I understand your dilema on what you did. Instead of typing in a unique Username you typed in your email address as your username. We'll do what we can to notify new users but if they make the mistake of using an email addy that's technically not the fault of OUJS.

[Lorentz83]

if they make the mistake of using an email addy that's technically not the fault of OUJS.

Is there a way to delete the account so I can create a new one with the GitHub username? I cannot find it.