Apply sort parm to URI for Graveyard #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Done previously in OpenUserJS#654 for public sortings * Add some *font-awesome* icons to the graveyard * Transform "All Types" to the correct nomenclature of "Clear Filters" * Change `href` to use parent plus `/removed` e.g. `./removed` static * Made User removal reason virtual instead of hard-coded... useful for Search filters e.g. reason is now blank when system generated... still don't allow a blank reason from a real author.. post fix for OpenUserJS#261 and pull OpenUserJS#513. This allows no reserved phrases other than string empty. * Some STYLEGUIDE.md conformance * DB remove model **migrated** as far back as "User removed" existed * Added some common needed Filters and reordered similar to GH... not all are implemented yet Closes OpenUserJS#526
Martii
added
bug
Martii
added a commit
that referenced
this pull request
Aug 4, 2015
Apply sort parm to URI for Graveyard Auto-merge
Member
Author
|
That's interesting the short GH hash got longer all by itself...
And one typo ... GRRR.... on "Discussion" filter... should be "Discussions"... will catch this on another commit... not worth making the noise on a plural... although maybe they all should be singular since it is a general search of removed items... ponders |
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
May 27, 2016
* A Userscript was incorrectly marking these for several years and missed a lot of them in the other views, so we'll mark the ones used for everyone depending on mode based on the current OUJS theme. * Skipping `author` since there's no actual th for that Applies a little to OpenUserJS#306, OpenUserJS#803, OpenUserJS#699, OpenUserJS#654, OpenUserJS#374 and a few others
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qurls if present #654 for public sortings"Clear Filters"... EDIT "Clear Search"... had it Filters initially.hrefto use parent plus/removede.g../removedstaticauthormoderator+... post fix for More modals needed for confirmation #261 and pull Support existing incompleted "reason" value for remove user and script #513. This allows no reserved phrases other than string empty.Closes #526