Handle username only prompt from management interface#801
Merged
selvanair merged 3 commits intoOpenVPN:masterfrom Apr 2, 2026
Merged
Handle username only prompt from management interface#801selvanair merged 3 commits intoOpenVPN:masterfrom
selvanair merged 3 commits intoOpenVPN:masterfrom
Conversation
Collaborator
Author
|
If the patch for username-only may make into 2.7.1 (??), it would be great to get this one in too. Its harmless even if openvpn.exe does ot support the new flag. |
Collaborator
Author
|
As username-only support is now in 2.7, would be nice to get a review of this. |
Signed-off-by: Selva Nair <selva.nair@gmail.com>
Current strtod(version_str) is unreliable when minor version exceeds 10. Signed-off-by: Selva Nair <selva.nair@gmail.com>
Effective only if "--auth-user-pass username-only" is in the config file and this variant is supported by OpenVPN core. Signed-off-by: Selva Nair <selva.nair@gmail.com>
selvanair
force-pushed
the
username-only
branch
from
85e93d2 to
34fd21a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 1: Improve OpenVPN version parsing -- helps with version comparison in next commit
commit 2: Prompt for username only when
>PASSWORD: Need 'Auth' usernamedirective is received. No change if the core does not support this feature.