Bump ApplicationVersion to 1.3.0.0#7
Conversation
Signed-off-by: Samuli Seppänen <samuli@openvpn.net>
|
Version 1.3.0.0 is released with openvpn 2.4_beta2. Is there some other place for the version number which would show up in "File properties" dialog in Windows? I don't think this has any effect there, but I could be wrong. I think we should start following the same procedure as for OpenVPN-GUI, that is, update version in sources and add two tags (e.g. 1.3.0.0 and openvpn-2.4_beta2). Thoughts? |
|
Yes, file properties show 0.0.0.0. I have no idea how to get the version into the exec. That said it would be nice to have version/build update and tags matching each release.. |
|
I'll look into getting the version number to File properties, and then force-push new stuff to this PR. |
This commit adds assembly metadata such as product version (now 1.3.0.0). This information will be shown in File -> Properties dialog in Windows Explorer. Signed-off-by: Samuli Seppänen <samuli@openvpn.net>
|
@selvanair : with the force-pushed changes the version numbers show up properly in File Properties -> Details. The only field I was unable to populate was "File description". A test build is here: Right now the version number is defined in five different places. This should be improved at some point. Setting the language field would have afaict required setting up satellite assemblies, i.e. localized AssemblyInfo files for each localization (e.g. en-US). I don't think that is worth the effort for openvpnserv2. |
| # Visual Studio 14 | ||
| VisualStudioVersion = 14.0.24720.0 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| # Visual Studio 2012 |
There was a problem hiding this comment.
It looks like MonoDevelop (which I use) and Visual Studio (used by someone else) are fighting each other here. I can revert this change if necessary.
|
I too use mono, so wouldn't care about this visual studio version change.. |
|
@selvanair : Ok, so I take that as an ACK? |
|
OK, checked the executable. Looks good. We have to just remember to update the version number (1.3.0.0) in two places (in AssemblyVersion.cs and the .csproj file). ACK. |
2 participants
No description provided.