docs: move contributor notes from CONTRIBUTING.md to README.md#26
Merged
stormer78 merged 5 commits intoOpenVTC:mainfrom Apr 15, 2026
Merged
Conversation
Signed-off-by: Nidhi Sharma <ns397048@gmail.com>
Signed-off-by: Nidhi Sharma <ns397048@gmail.com>
stormer78
reviewed
Apr 11, 2026
Contributor
stormer78
left a comment
stormer78
left a comment
There was a problem hiding this comment.
This should reside in the README.md not the CONTRIBUTING.md file
4 tasks
Contributor
|
@nidhi-9900 Can you respond to this? otherwise this will be automatically closed. |
Signed-off-by: Nidhi Sharma <ns397048@gmail.com>
Signed-off-by: Nidhi Sharma <ns397048@gmail.com>
Signed-off-by: Nidhi Sharma <ns397048@gmail.com>
Contributor
Author
|
Sorry for the late reply. Moved the notes to README.md and fixed the conflict. |
nidhi-9900
changed the title
stormer78
added a commit
that referenced
this pull request
Apr 15, 2026
Resolves conflicts from PRs #41 (SecretString hardening), #33 (typo fixes), #26 (docs), and #43 (Windows docs) merging into main. Conflict resolutions: - cli.rs: kept openpgp-card cfg gate + anyhow::Result return type - main.rs: adopted centralized process_lock, kept redact_paths helper - state_handler/mod.rs: adopted channel-based TokenNotifier, kept LogFamily import - setup_sequence/config.rs: combined expose_secret() with proper map_err handling - settings_actions.rs: updated unlock_code to use SecretBox wrapper Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13
Moved the Getting Started, Workspace Layout, Building, Testing and PR Guidelines sections from CONTRIBUTING.md to README.md as requested in review.
Also resolved the merge conflict in CONTRIBUTING.md after upstream changes.