fix(build): import arboard::Clipboard + bump vta-sdk to 0.7#62
Merged
Conversation
The clipboard-clear logic added in 56b3642 references `Clipboard::new()` and `clipboard.get_text()` without importing `arboard::Clipboard`. The adjacent [C] copy handler goes through `crate::clipboard::copy_to_clipboard` (an OSC 52 / arboard abstraction) which is why the file had no direct arboard import, and why the regression slipped past local `cargo check --all-features` but failed default-features CI on PR #61 with E0433. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
Picks up the 0.7.0 release of the Verifiable Trust Infrastructure SDK (github.com/OpenVTC/verifiable-trust-infrastructure). No API changes required at the openvtc call sites — workspace builds clean under default and --no-default-features, tests and clippy pass. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
Pulls the latest compatible patch versions of the Affinidi / VTA / WASM dependency stacks: affinidi-crypto 0.1.5 -> 0.1.6 affinidi-messaging-mediator 0.15.3 -> 0.15.4 affinidi-messaging-test-mediator 0.2.2 -> 0.2.3 didwebvh-rs 0.5.2 -> 0.5.3 vta-sdk 0.5.0 -> 0.7.0 (lockfile resync) serde_json 1.0.149 -> 1.0.150 autocfg, bumpalo, js-sys, wasm-bindgen*, web-sys No Cargo.toml ranges changed beyond the explicit vta-sdk minor bump in the previous commit. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
vta-sdk 0.7 moves `access_token`, `access_expires_at` and `refresh_token` off `WebvhServerRecord` and into a separate service-internal `WebvhServerAuthRecord` (keyspace prefix `server-auth:`). Public-surface records no longer carry token material so they don't leak into REST list responses, DIDComm `webvh.servers.list` results, or backup exports. Update the navigation test fixture to construct the new shape. Detected by default-features CI on PR #61 / #62 (`(bin "openvtc" test)` target) with E0560. Masked locally because earlier verification piped `cargo test --workspace` through `tail`, dropping cargo's non-zero exit code. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
The workspace declares `rust-version = "1.95.0"` and `did-git-sign` depends on language features (e.g. let-chains) that require it, but the dedicated MSRV CI job still pinned `dtolnay/rust-toolchain@1.94.0`. That job has been red since the workspace rust-version was bumped; align the pin with the declared floor so MSRV verifies the version we actually support. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
CI runs `cargo clippy --workspace --all-targets -- -D warnings`.
Several lints that were warning-only in 1.94 became enforced after the
workspace rust-version bumped to 1.95, leaving clippy red on main:
did-git-sign/src/main.rs collapsible_else_if (uninstall scope)
openvtc-core/tests/relationship_e2e.rs
explicit_auto_deref on `*type_url`
openvtc/src/state_handler/message_dispatch.rs
items_after_test_module — move
`mod tests` to file end (matches
sibling modules' convention)
openvtc/src/state_handler/mod.rs collapsible_if on the VTA-context
lookup; collapse into a single
chained `if matches!(...) && let ...`
openvtc/src/state_handler/settings_actions.rs
collapsible_match — hoist
`field == 0` into the pattern guard
openvtc/src/state_handler/setup_wizard.rs
collapsible_match — `VtaCreateKeys`
hoists cleanly; the two arms that
bind owned values (`server_id`,
`custom_path`, `webvh_address`)
can't move into a match guard
(E0507), so keep the inner-if form
and `#[allow]` the lint locally
openvtc/src/ui/pages/main/mod.rs collapsible_match on Up / Down arms
openvtc/src/ui/pages/setup_flow/mod.rs
default_constructed_unit_structs
(`DidGitSignSetup` is a unit struct)
No behaviour changes; pure refactors. Verified with
`cargo clippy --workspace --all-targets -- -D warnings` clean and
`cargo build --workspace [--no-default-features]` passing.
Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI build failure introduced by #61 and bumps the VTA SDK plus the rest of the Affinidi-family deps. No version bump — v0.2.1 hasn't been published yet.
Commits
2cb219dfix(build): importarboard::Clipboardindid_keys_export_show— the clipboard-clear logic from patch 8 of fix(security): nine CLI security/hardening fixes — release v0.2.1 #61 referencesClipboard::new()/clipboard.get_text()without importingarboard::Clipboard. The adjacent[C]copy handler goes throughcrate::clipboard::copy_to_clipboard(the OSC 52 / arboard abstraction), which is why the file had no direct arboard import and why localcargo check --all-featurespassed but default-features CI failed withE0433: cannot find type Clipboard in this scope.34f605fchore(deps): bump vta-sdk 0.6 → 0.7 — picks up the 0.7.0 release of the Verifiable Trust Infrastructure SDK. No call-site changes required.5234f8achore(deps): cargo update — latest compatible patch versions ofaffinidi-crypto,affinidi-messaging-mediator,affinidi-messaging-test-mediator,didwebvh-rs,vta-sdk(lockfile resync 0.5.0 → 0.7.0),serde_json, and the WASM stack.Why no version bump
Per maintainer guidance: v0.2.1 from #61 hasn't been published; this PR ships under the same 0.2.1 tag once it's tagged.
Test plan
cargo build --workspace(default features) — passescargo build --workspace --no-default-features— passescargo test --workspace— passescargo clippy --workspace --all-targets— cleancargo fmt --check— cleanTest (ubuntu-latest),Test (no default features),Coverage, MSRV)