Update Magic-HD-Night/Noire for new VirtualKeyBoard#54
Update Magic-HD-Night/Noire for new VirtualKeyBoard#54AbuBaniaz merged 3 commits intoOpenViX:masterfrom
Conversation
Update skin for compatibility with the new VirtualKeyBoard.
Add new images for the updated VirtualKeyBoard.
Add new images for the updated VirtualKeyBoard.
|
The png files in the defaultfallback skin are used. Do you still want this merged? |
|
The changes to the skin XML file are needed. When I tested the new XML file the images did not get loaded. When I added the images they were found. Can you test just the XML change and see if you experience similar results. |
|
I have tried this several times, it works without any changes. I am presuming that the person on forum removed the fallback skin. If I rename the default skin folder, keyboard does not show. Not a problem merging, but please be sure. |
|
Please give the merge a try. We can always revert if there is a problem. Given that this skin has been abandoned by the person you copied it from Rob perhaps it should be removed entirely and ask the user to move onto one of Rob's supported skins? |
|
You can't even uninstall the default skin. So was a manual removal. It works as it is. I'll someone else decide. IMO, we are better off making other skins same as this instead of duplication. Pity there is no 1080 default skin |
|
Sooner or later we need to get round to using SVG images. |
|
I tried to propose a multi resolution default skin. No-one seemed interested. |
|
By the way, I have the new VirtualKeyBoard images in skin_default yet the Magic-HD-Night skin could not load the images. The XML file is definitely in need of change. |
|
@AbuBaniaz: Did you test the "ViX-HD-Night" skin or the "Magic-HD-Night" skin? The problems are with "Magic-HD-Night" (and "Magic-HD-Noire"). |
|
Ian, there is no problem. I checked Delagroov's skin. |
|
Weird, two receivers were fine, third was not. So merged it. |
|
The changes I submitted should be safe and fine even if the skin_default images are working. :) |
This reverts commit 12c8983. Reverted as it breaks the build. configure.ac must be edited when adding folders to a Makefile. Please resubmit pull request when corrected.
3 participants
[Magic-HD-Night] Update VirtualKeyBoard images
Add new images for the updated VirtualKeyBoard.
[Magic-HD-Noire] Update VirtualKeyBoard images
Add new images for the updated VirtualKeyBoard.
[CommonSkin.xml] VirtualKeyBoard update
Update skin for compatibility with the new VirtualKeyBoard.