Optimise PopsAggregate by using IndexedFlatMaps#734
Merged
Conversation
wvpm
force-pushed
the
optimise_pops_aggregate_via_indexing
branch
from
abd629b to
d6d3e5d
Compare
wvpm
force-pushed
the
optimise_pops_aggregate_via_indexing
branch
3 times, most recently
from
8d0d0c3 to
1b9e71c
Compare
Spartan322
reviewed
May 19, 2026
wvpm
force-pushed
the
optimise_pops_aggregate_via_indexing
branch
2 times, most recently
from
524279f to
016dd41
Compare
Spartan322
force-pushed
the
optimise_pops_aggregate_via_indexing
branch
from
016dd41 to
3d53f45
Compare
Spartan322
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexedFlatMap is much faster than fixed_point_map_t as that uses hash-based lookups whilst the former uses indexing.
Since this code is called every gamestate update, it is a hot-path and thus performance matters here.
Note breaks godot, I'll fix that later.