Move STL-like container headers to core/stl/containers#744
Open
Spartan322 wants to merge 1 commit into
Open
Conversation
Spartan322
force-pushed
the
add/stl-like-containers
branch
2 times, most recently
from
45f5685 to
6fd5c56
Compare
wvpm
reviewed
May 20, 2026
wvpm
reviewed
May 20, 2026
wvpm
reviewed
May 20, 2026
wvpm
reviewed
May 20, 2026
wvpm
reviewed
May 20, 2026
wvpm
reviewed
May 20, 2026
wvpm
reviewed
May 20, 2026
wvpm
reviewed
May 20, 2026
wvpm
reviewed
May 20, 2026
wvpm
reviewed
May 20, 2026
wvpm
reviewed
May 20, 2026
wvpm
reviewed
May 20, 2026
wvpm
requested changes
May 20, 2026
Spartan322
force-pushed
the
add/stl-like-containers
branch
from
6fd5c56 to
b3f4817
Compare
Spartan322
force-pushed
the
add/stl-like-containers
branch
2 times, most recently
from
bdb5122 to
0c289ed
Compare
Includes: - CowPtr - CowVector - FixedVector - RingBuffer - StackString - TypedSpan Move allocator aware STL-like containers to `OpenVic::stl` namespace Includes: - CowPtr - CowVector - FixedVector - RingBuffer Move BasicIterator to `core/stl` Move TslHelper.hpp to `core/stl` and rename to MutableIterator.hpp Move memory container type aliases to `core/memory` Add memory type alias for cow_ptr Add memory type alias for cow_vector Move FixedVector from namespace `OpenVic::_detail` to `OpenVic::stl` Add stateful allocator support to FixedVector's constructors Replace assert in TypedSpan with `OV_HARDEN_ASSERT_ACCESS` Move STL-like container unit tests to `core/stl/containers`
Spartan322
force-pushed
the
add/stl-like-containers
branch
from
0c289ed to
b2c561e
Compare
wvpm
reviewed
May 20, 2026
| _allocator(), | ||
| _data_start_ptr(allocator_traits::allocate(_allocator, capacity)) {} | ||
|
|
||
| constexpr FixedVector(const size_t capacity, std::type_identity_t<Allocator> const& alloc) |
Contributor
There was a problem hiding this comment.
You need to either generate values, use a provided value that you can copy or create it empty based on the constructor tags.
wvpm
approved these changes
May 20, 2026
Contributor
wvpm
left a comment
wvpm
left a comment
There was a problem hiding this comment.
Support constructor tags in FixedVector and this is ready for merge 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes:
Move allocator aware STL-like containers to
OpenVic::stlnamespaceIncludes:
Move BasicIterator to
core/stlMove TslHelper.hpp to
core/stland rename to MutableIterator.hppMove memory container type aliases to
core/memoryAdd memory type alias for cow_ptr
Add memory type alias for cow_vector
Move FixedVector from namespace
OpenVic::_detailtoOpenVic::stlAdd stateful allocator support to FixedVector's constructors
Replace assert in TypedSpan with
OV_HARDEN_ASSERT_ACCESSMove STL-like container unit tests to
core/stl/containers