Skip to content

Prepare for IdentifierRegistry replacement#758

Merged
wvpm merged 1 commit into
devfrom
prepare_for_identifierregsitry_refactor
May 25, 2026
Merged

Prepare for IdentifierRegistry replacement#758
wvpm merged 1 commit into
devfrom
prepare_for_identifierregsitry_refactor

Conversation

@wvpm
Copy link
Copy Markdown
Contributor

@wvpm wvpm commented May 25, 2026

This PR is split off from #754 and prepares for it.

  1. Store indices instead of pointers
  2. Remove the combined unit_types registry and only use the separate registries

@wvpm wvpm requested a review from a team as a code owner May 25, 2026 09:11
@wvpm wvpm force-pushed the prepare_for_identifierregsitry_refactor branch from 2e49ca5 to 5bebf5f Compare May 25, 2026 09:12
@wvpm wvpm force-pushed the prepare_for_identifierregsitry_refactor branch from 3ab13fd to d0d8104 Compare May 25, 2026 09:52
Copy link
Copy Markdown

@Catylist0 Catylist0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem inoffensive unless I am missing something overt. Unless someone else pipes up with a specific concern I am happy to rubber-stamp this

@wvpm wvpm force-pushed the prepare_for_identifierregsitry_refactor branch from d0d8104 to 7ed3847 Compare May 25, 2026 09:58
@wvpm wvpm force-pushed the prepare_for_identifierregsitry_refactor branch from 7ed3847 to 798a19a Compare May 25, 2026 09:58
@wvpm wvpm merged commit ae11fdd into dev May 25, 2026
2 checks passed
@wvpm wvpm deleted the prepare_for_identifierregsitry_refactor branch May 25, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants