MSG-1: shared vocabulary hoist + SESSION-1 deferral (draft)#23
Merged
Conversation
|
Warning Review limit reached
Your plan includes 1 review of capacity. Refill in 23 minutes and 3 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
§2.1.1 (new) — fix the colon/dot/whitespace forbidden rule for any identifier that other specs mint for use as a structural component of a topic name (skill_id, pipeline_id, transformer_id, intent_name, component_id, …). Replaces per-spec restatement of the same rule in PIPELINE-1 §7, CONTEXT-1 §2/§3, TRANSFORM-1 §1, etc. §4 / §4.1 / §4.3 / §7 — defer the wire shape of `session`, the `session_id` value space, the reserved `"default"` marker, the omission-as-deferral semantics, and the closed field set to the new OVOS-SESSION-1. This spec retains: the fact that `session` is the carrier inside `Message.context`, the naming of `session_id` / `lang`, and the propagation rule across forward/reply/response. §4.2 (`lang`) unchanged — remains owned here. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
JarbasAl
force-pushed
the
spec/msg1-shared-vocabulary
branch
from
fd4c510 to
fbbe93c
Compare
…ternals Per design principle: a forward-reference to another spec's section is a smell that the definition belongs in the other spec and should not appear here. MSG-1 owns the existence of `session` as a context key and its propagation rule; everything inside session is SESSION-1's, and MSG-1 should not name it. Removed: - All `session_id` mentions (preamble, §1, §5, §5.4, §7). - All `OVOS-SESSION-1 §X` forward-references (§4, §5.1, §7, See also). - The "reserved \"default\" marker" prose in conformance. Retained: - The bare statement that `session` rides inside Message.context and that its shape/fields/semantics live in OVOS-SESSION-1. - The propagation rule (which is MSG-1's, not SESSION-1's). - One See-also line pointing readers at SESSION-1 by name only. Also: fix a broken half-sentence in the preamble left by an earlier edit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
message-object.md (1)
338-339:⚠️ Potential issue | 🟠 Major | ⚡ Quick winBroken section reference to non-existent §4.3
Line 339 points to
§4.3, but section 4 currently ends at§4.2. This creates a dead normative reference in derivation behavior.Suggested fix
- session on the result (§4.3). + session on the result (§4.1).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@message-object.md` around lines 338 - 339, The reference "§4.3" in the sentence "populate a default session on the result (§4.3)" is dead because section 4 currently ends at §4.2; update the reference to point to the correct target (either change "§4.3" to "§4.2" if that is the intended section, or add the missing §4.3 section with the normative text about default session derivation) and ensure the phrasing and cross-reference in message-object.md and any related headings (e.g., the text that explains default session behavior) are consistent so the normative link resolves correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@message-object.md`:
- Around line 464-465: The cross-reference "§4.4" in the phrase "opaque layer-2
substrate of §3.4 / §4.4." is invalid; update that reference to point to the
actual section that defines "session’s layer-2 substrate framing" (or replace
the numeric reference with the explicit section title if uncertain). Locate the
exact text fragment "opaque layer-2 substrate of §3.4 / §4.4." and change "§4.4"
to the correct section number or the section heading that defines the session
layer-2 substrate framing so the cross-reference is accurate.
---
Outside diff comments:
In `@message-object.md`:
- Around line 338-339: The reference "§4.3" in the sentence "populate a default
session on the result (§4.3)" is dead because section 4 currently ends at §4.2;
update the reference to point to the correct target (either change "§4.3" to
"§4.2" if that is the intended section, or add the missing §4.3 section with the
normative text about default session derivation) and ensure the phrasing and
cross-reference in message-object.md and any related headings (e.g., the text
that explains default session behavior) are consistent so the normative link
resolves correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OVOS-MSG-1 — Bus Message Specification
Two scoped changes to MSG-1.
§2.1.1 — topic-component identifier rule
Identifiers used as structural components of a topic name (skill IDs, pipeline IDs, intent names, transformer IDs, context keys, etc.) MUST NOT contain
:,., or whitespace. These characters are reserved for the segmenting and routing conventions of MSG-1. Specs that mint such identifiers reference this rule rather than restating it.§4 —
sessioncarrier ownershipMSG-1 owns the existence of
Message.context.sessionas the carrier, the namessession_idandlang, and the propagation rule that derivations preservesessionunchanged. The wire shape, field set, registry mechanism, omission semantics, and the reservedsession_id == "default"value are owned by OVOS-SESSION-1.Out of scope
sessionbeyond namingsession_idandlang.Status
Draft.