Skip to content

fix(i18n): normalize locale folders to canonical BCP-47#392

Merged
JarbasAl merged 1 commit into
devfrom
fix/locales
Apr 3, 2026
Merged

fix(i18n): normalize locale folders to canonical BCP-47#392
JarbasAl merged 1 commit into
devfrom
fix/locales

Conversation

@JarbasAl
Copy link
Copy Markdown
Member

@JarbasAl JarbasAl commented Apr 3, 2026

Summary

  • Normalize all locale folder names to canonical BCP-47 form (e.g. da-dk → da-DK, da → da-DK)
  • Merge duplicate locale directories that differ only in case
  • Remove nested bare-language subdirectories (e.g. eu-ES/eu/ → eu-ES/)
  • Fixes wheel/sdist build failures: ZIP file contains multiple entries with different contents

Test plan

  • Verify pip install . / uv pip install . builds without ZIP duplicate errors
  • Verify locale files load correctly at runtime

🤖 Generated with Claude Code

@JarbasAl @claude
fix(i18n): normalize locale folder names to canonical BCP-47 form
74b42da 
Rename all locale directories to use canonical BCP-47 codes:
- Lowercase regions → uppercase (da-dk → da-DK, en-us → en-US)
- Bare language codes → full BCP-47 (da → da-DK, eu → eu-ES)
- Invalid codes remapped (eu-eu → eu-ES, fa-fa → fa-IR)
- Nested bare-language subdirs merged up (eu-ES/eu/ → eu-ES/)

This fixes wheel build failures caused by ZIP files containing
duplicate entries with different contents for the same logical path.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the fix label Apr 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 3, 2026

Warning

Rate limit exceeded

@JarbasAl has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 55 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 55 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6c341b5b-741c-452d-9f8f-194a2753a451

📥 Commits

Reviewing files that changed from the base of the PR and between ea76fe2 and 74b42da.

📒 Files selected for processing (42)
  • ovos_workshop/locale/az-AZ/word_connectors.json
  • ovos_workshop/locale/ca-ES/word_connectors.json
  • ovos_workshop/locale/cs-CZ/noise_words.list
  • ovos_workshop/locale/cs-CZ/word_connectors.json
  • ovos_workshop/locale/da-DK/word_connectors.json
  • ovos_workshop/locale/de-DE/noise_words.list
  • ovos_workshop/locale/de-DE/word_connectors.json
  • ovos_workshop/locale/en-US/cancel.voc
  • ovos_workshop/locale/en-US/cant_load_game.dialog
  • ovos_workshop/locale/en-US/cant_save_game.dialog
  • ovos_workshop/locale/en-US/game_pause.dialog
  • ovos_workshop/locale/en-US/game_unpause.dialog
  • ovos_workshop/locale/en-US/noise_words.list
  • ovos_workshop/locale/en-US/skill.error.dialog
  • ovos_workshop/locale/en-US/word_connectors.json
  • ovos_workshop/locale/es-ES/word_connectors.json
  • ovos_workshop/locale/fa-IR/word_connectors.json
  • ovos_workshop/locale/fr-FR/cancel.voc
  • ovos_workshop/locale/fr-FR/cant_load_game.dialog
  • ovos_workshop/locale/fr-FR/cant_save_game.dialog
  • ovos_workshop/locale/fr-FR/game_pause.dialog
  • ovos_workshop/locale/fr-FR/game_unpause.dialog
  • ovos_workshop/locale/fr-FR/noise_words.list
  • ovos_workshop/locale/fr-FR/skill.error.dialog
  • ovos_workshop/locale/fr-FR/word_connectors.json
  • ovos_workshop/locale/gl-ES/word_connectors.json
  • ovos_workshop/locale/it-IT/word_connectors.json
  • ovos_workshop/locale/nl-NL/skill.error.dialog
  • ovos_workshop/locale/nl-NL/word_connectors.json
  • ovos_workshop/locale/pl-PL/word_connectors.json
  • ovos_workshop/locale/pt-PT/word_connectors.json
  • ovos_workshop/locale/ru-RU/noise_words.list
  • ovos_workshop/locale/sl-SI/word_connectors.json
  • ovos_workshop/locale/uk-UA/word_connectors.json
  • test/unittests/ovos_tskill_abort/locale/en-US/question.dialog
  • test/unittests/ovos_tskill_abort/locale/en-US/test.intent
  • test/unittests/ovos_tskill_abort/locale/en-US/test2.intent
  • test/unittests/ovos_tskill_abort/locale/en-US/test3.intent
  • test/unittests/skills/test_locale/locale/en-US/dow.entity
  • test/unittests/skills/test_locale/locale/en-US/time.intent
  • test/unittests/skills/test_locale/locale/uk-UA/dow.entity
  • test/unittests/skills/test_locale/locale/uk-UA/time.intent
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/locales

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026 •
edited
Loading

Look what I found! The automated check results are in. 🔍

I've aggregated the results of the automated checks for this PR below.

📋 Repo Health

Scanning for any signs of repository fatigue. 😫

✅ All required files present.

Latest Version: 8.0.1a5

✅ ovos_workshop/version.py — Version file
✅ README.md — README
✅ LICENSE — License file
✅ pyproject.toml — pyproject.toml
✅ CHANGELOG.md — Changelog
⚠️ requirements.txt — Requirements
✅ ovos_workshop/version.py has valid version block markers

⚖️ License Check

Reading the fine print so you don't have to! 🔎

✅ No license violations found (47 packages).

License distribution: 12× MIT License, 8× MIT, 6× Apache Software License, 6× Apache-2.0, 2× BSD-3-Clause, 2× ISC License (ISCL), 2× PSF-2.0, 2× Python Software Foundation License, +7 more

Full breakdown — 47 packages
Package Version License URL
audioop-lts 0.2.2 PSF-2.0 link
build 1.4.2 MIT link
certifi 2026.2.25 Mozilla Public License 2.0 (MPL 2.0) link
charset-normalizer 3.4.7 MIT link
click 8.3.1 BSD-3-Clause link
combo_lock 0.3.1 Apache-2.0 link
filelock 3.25.2 MIT link
idna 3.11 BSD-3-Clause link
importlib_metadata 9.0.0 Apache-2.0 link
json-database 0.10.1 MIT link
kthread 0.2.3 MIT License link
langcodes 3.5.1 MIT License link
markdown-it-py 4.0.0 MIT License link
mdurl 0.1.2 MIT License link
memory-tempfile 2.2.3 MIT License link
ovos-config 2.1.1 Apache-2.0 link
ovos-number-parser 0.5.1 Apache Software License link
ovos-plugin-manager 2.2.0 Apache-2.0 link
ovos-solver-yes-no-plugin 0.2.8 MIT link
ovos-utils 0.8.5 Apache-2.0 link
ovos-workshop 8.0.1a5 Apache-2.0 link
ovos_bus_client 1.5.0 Apache Software License link
packaging 26.0 Apache-2.0 OR BSD-2-Clause link
padacioso 1.0.0 apache-2.0 link
pexpect 4.9.0 ISC License (ISCL) link
ptyprocess 0.7.0 ISC License (ISCL) link
pyee 12.1.1 MIT License link
Pygments 2.20.0 BSD-2-Clause link
pyproject_hooks 1.2.0 MIT License link
python-dateutil 2.9.0.post0 Apache Software License; BSD License link
PyYAML 6.0.3 MIT License link
quebra-frases 0.3.7 Apache Software License link
RapidFuzz 3.14.3 MIT link
regex 2026.3.32 Apache-2.0 AND CNRI-Python link
requests 2.33.1 Apache Software License link
rich 13.9.4 MIT License link
rich-click 1.9.7 MIT License

Copyright (c) 2022 Phil Ewels

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
| link |
| simplematch | 1.4 | MIT License | link |
| six | 1.17.0 | MIT License | link |
| standard-aifc | 3.13.0 | Python Software Foundation License | link |
| standard-chunk | 3.13.0 | Python Software Foundation License | link |
| typing_extensions | 4.15.0 | PSF-2.0 | link |
| unicode-rbnf | 2.4.0 | MIT License | |
| urllib3 | 2.6.3 | MIT | link |
| watchdog | 6.0.0 | Apache Software License | link |
| websocket-client | 1.9.0 | Apache Software License | link |
| zipp | 3.23.0 | MIT | link |

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔍 Lint

Checking the boxes and crossing the T's. 🖋️

❌ ruff: issues found — see job log

🔒 Security (pip-audit)

Ensuring our password hashing is up to date. 🔨

✅ No known vulnerabilities found (66 packages scanned).

🔨 Build Tests

Checking the plumbing of your data flows. 🚰

Python Build Install Tests
3.10 ✅ ✅ ⚠️
3.11 ✅ ✅ ⚠️
3.12 ✅ ✅ ⚠️
3.13 ✅ ✅ ⚠️
3.14 ✅ ✅ ⚠️

❌ 3.10: Install OK, tests failed
❌ 3.11: Install OK, tests failed
❌ 3.12: Install OK, tests failed
❌ 3.13: Install OK, tests failed
❌ 3.14: Install OK, tests failed
Check job logs for details.

From the digital workshop of OpenVoiceOS. 🛠️

@JarbasAl JarbasAl merged commit e12559e into dev Apr 3, 2026
6 of 16 checks passed
@JarbasAl JarbasAl deleted the fix/locales branch April 8, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JarbasAl