fpm: Don't set --rpm-rpmbuild-define#102
Merged
Merged
Conversation
under the hood, fpm calls rpmbuild. Under EL9, the fpm option
`--rpm-rpmbuild-define` worked fine and was set to the version of the
actual package. This was probably never correct. It maps to the rpm
macro `%rpmversion`. This is supposed to be used for the *rpm* version
used during the build. rpmbuild on EL10 will set `%rpmversion`
automatically and fpm cannot provide it as well. We also set the actual
version here:
```
shared_opts << "--version #{options.version}"
```
And this is around since the introduction of fpm in
ba3315c.
Also Zhenech confirmed that we can remove `--rpm-rpmbuild-define`.
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
|
The rpm/deb packages and the JAR file for OpenVoxProject/ezbake are available in a zip archive: The rpm/deb packages and the JAR file for OpenVoxProject/ezbake are available in a zip archive: |
Contributor
Author
|
reference: our latest stable packages from yum.voxpupuli.org: |
Contributor
Author
|
Updated openvoxdb / openvoxdb-termini: |
Contributor
Author
|
openvox-server: |
tuxmea
approved these changes
May 29, 2026
bastelfreak
added a commit
to OpenVoxProject/openvox-server
that referenced
this pull request
May 29, 2026
This contains a fixed fpm call, which is required for building on EL10 hosts: OpenVoxProject/ezbake#102 Signed-off-by: Tim Meusel <tim@bastelfreak.de>
bastelfreak
added a commit
to OpenVoxProject/openvox-server
that referenced
this pull request
May 29, 2026
This contains a fixed fpm call, which is required for building on EL10 hosts: OpenVoxProject/ezbake#102 Signed-off-by: Tim Meusel <tim@bastelfreak.de>
bastelfreak
added a commit
to OpenVoxProject/openvox-server
that referenced
this pull request
May 29, 2026
This contains a fixed fpm call, which is required for building on EL10 hosts: OpenVoxProject/ezbake#102 Signed-off-by: Tim Meusel <tim@bastelfreak.de>
bastelfreak
added a commit
to OpenVoxProject/openvox-server
that referenced
this pull request
May 29, 2026
This contains a fixed fpm call, which is required for building on EL10 hosts: OpenVoxProject/ezbake#102 Signed-off-by: Tim Meusel <tim@bastelfreak.de>
bastelfreak
added a commit
to OpenVoxProject/openvox-server
that referenced
this pull request
May 29, 2026
This contains a fixed fpm call, which is required for building on EL10 hosts: OpenVoxProject/ezbake#102 Signed-off-by: Tim Meusel <tim@bastelfreak.de>
bastelfreak
added a commit
to OpenVoxProject/openvox-server
that referenced
this pull request
May 29, 2026
This contains a fixed fpm call, which is required for building on EL10 hosts: OpenVoxProject/ezbake#102 Signed-off-by: Tim Meusel <tim@bastelfreak.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
under the hood, fpm calls rpmbuild. Under EL9, the fpm option
--rpm-rpmbuild-defineworked fine and was set to the version of the actual package. This was probably never correct. It maps to the rpm macro%rpmversion. This is supposed to be used for the rpm version used during the build. rpmbuild on EL10 will set%rpmversionautomatically and fpm cannot provide it as well. We also set the actual version here:And this is around since the introduction of fpm in ba3315c.
Also Zhenech confirmed that we can remove
--rpm-rpmbuild-define.Pull Request (PR) description
This Pull Request (PR) fixes the following issues