Remove pending when testing StringConverter with JRuby#139
Merged
bastelfreak merged 1 commit intomainfrom Jun 20, 2025
Merged
Conversation
The version of JRuby we are using do support the `%a` format. This result in a bunch of extra failures on JRuby because the tests are expected to fail but are actually passing. Remove the pending and make the test ensure the result is the expected on on JRuby.
smortex
changed the title
pending when testing StringConverter with JRuby
bastelfreak
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of JRuby we are using do support the
%aformat. Thisresult in a bunch of extra failures on JRuby because the tests are
expected to fail but are actually passing.
Remove the pending and make the test ensure the result is the expected
on on JRuby.